Introduce FaceRef and use it to wrap any un-resolved Faces
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to be able to dispatch into StyledStrings for display logic for these annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 on #99 (solves the same type-piracy problem without changing the face-resolution semantics). This will allow us to dispatch into StyledStrings for display of these Faces / annotations.
I'm still not a fan of the lazy resolution semantics here (I would prefer to have a separate
lazystyledmacro for the delayed resolution / user-customizable styling and themergeimplementation is still flawed since it partially forces eager resolution), but one way or another this type-piracy needs to be resolved.