-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use three-valued logic with missing values in ==(::Tuple, ::Tuple) #24963
Conversation
For consistency with AbstractArray.
@nanosoldier |
@test ismissing(("a", missing) == ("a", missing)) | ||
@test ismissing((missing,) == (missing,)) | ||
@test ismissing((missing, 2) == (1, missing)) | ||
@test !((missing, 1) == (missing, 2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be missing something super obvious, but how is this different than the test a few lines down that does !=
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's the same since the fallback is defined using ==
, but that's the assumption we're checking. :-)
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
OK, the "simd/local_arrays" regression cannot possibly be related. The "tuple/reduction" benchmark doesn't use |
I'll merge tomorrow barring objections. |
LGTM: the scheme is that |
Yes. BTW, I've noticed |
Circle CI failures look legit and related, btw. |
No, AFAICT that's #24984. Let's see what a new run says. |
CircleCI still fails, but with |
For consistency with
AbstractArray
(missed by #24653).Also add a test for the special case when the result of equality test is not
missing
even in the presence of missing values.