Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type stability of Broadcast.flatten #28111

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

mbauman
Copy link
Member

@mbauman mbauman commented Jul 13, 2018

Fixes #27988.

@mbauman
Copy link
Member Author

mbauman commented Jul 13, 2018

The rule that I was forgetting here is that inference no longer likes passing recursively-growing tuples as arguments. We always want the part involved in the recursion to be shrinking, not growing. This recursively passes fewer and fewer arguments.

@JeffBezanson JeffBezanson merged commit 67b06af into master Jul 20, 2018
@JeffBezanson JeffBezanson deleted the mb/flat-and-stable-broadcasting branch July 20, 2018 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants