WIP: Backports for 1.0.2 #29444
Merged
WIP: Backports for 1.0.2 #29444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref. https://discourse.julialang.org/t/error-undefvarerror-eigvecs-not-defined/14923/2?u=stillyslalom (cherry picked from commit 2c15430)
(cherry picked from commit 157a6d1)
(cherry picked from commit abe38f1)
The example used identifier `x` for two different purposes. While this isn't a problem for Julia, it makes humans have to read much more carefully. For examples I think it is much clearer to use different identifiers for different purposes. (cherry picked from commit 6354405)
Minor language fixes. Two more significant changes are: * it is recommended to use `===` to compare to `nothing` * `=` is not a binary operator (cherry picked from commit 27de698)
(cherry picked from commit b777030)
(cherry picked from commit ce64546)
I spotted a typo when reviewing the merge. (cherry picked from commit 338cf0d)
(cherry picked from commit 60e6794)
The R function is called is.na, and automatically works element-wise. (cherry picked from commit 8484f97)
(cherry picked from commit 0b5e21c)
(cherry picked from commit c37f4aa)
(cherry picked from commit 94aa39b)
* gemm_wrapper! -> mul! (#29224) * testing for #29224 * code review update: More tests * Complex times real reinterpret trick fix for vectors and transposed matrices (cherry picked from commit 82503cd)
…29258) This implements the suggestion in #27857 (comment) (cherry picked from commit 8d6c1ce)
(cherry picked from commit 493068b)
(cherry picked from commit 47668c8)
(cherry picked from commit ba41f69)
(cherry picked from commit bc34c64)
(cherry picked from commit e1f42b1)
Move whereas clause into subordinate position to avoid sentence fragment. (cherry picked from commit 8907aff)
(cherry picked from commit be1ae20)
(cherry picked from commit 82c4fce)
(cherry picked from commit b72fc4c)
* propgate inbounds to substring and use it in split * remove Base prefix (cherry picked from commit 18b9fc2)
(cherry picked from commit 5c2e0b5)
(cherry picked from commit 2885b62)
(cherry picked from commit 0e023d0)
* speed up logical indexing by bitarray * changed inbounds / OOB behavior to match array iterators switched spelling of _blsr * Update base/multidimensional.jl Co-Authored-By: chethega <[email protected]> (cherry picked from commit 44f2563)
(cherry picked from commit aa72f72)
* Remove Pkg from the JuliaLang/julia repo. * Use git-external to install Pkg during build. (cherry picked from commit 1717adb)
Fixes #29723 (cherry picked from commit a472bc7)
(cherry picked from commit 5e9feb4)
(cherry picked from commit 07ea302)
Co-authored-by: Jameson Nash <[email protected]> (cherry picked from commit 6ae6551)
* fix bug and add tests * Reinstate statically computed log record ids Log ids are meant to identify the location of the message in the source code and must be computed at compile time. fix #28786, fix #28400; closes #29355. * Clarify documentation regarding log record `id` (cherry picked from commit 51683c4)
(cherry picked from commit 1bbea22)
KristofferC
force-pushed
the
backport_102
branch
from
03c733c to
8ae1d48
Compare
ararslan
removed
the
needs pkgeval
|
PkgEval says we're all good now. 😎 |
|
Merge and announce a short testing period like last time? |
|
Sounds good to me. |
|
Thanks for all of your awesome work here, Kristoffer! |
|
Testing period announcement: https://discourse.julialang.org/t/julia-1-0-2-testing-period/17121?u=ararslan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
Nothing#29210 - correct the docs ofNothingn > typemax(n)÷2#29205 - fix digits(n::Unsigned) with neg base forn > typemax(n)÷2using LinearAlgebraexplicit #29188 - Makeusing LinearAlgebraexplicitUnion{}result from type intersection #29380 - fix another bug which crashes julia 1.0 and latest nightly 1.1.0 #29208, incorrectUnion{}result from type intersectionsizeof(str::AbstractString)docstring #29414 - fixsizeof(str::AbstractString)docstringwhich#29419 - fix Reflection functions should handleUnionAll#20872, handle UnionAll types inwhichStringis not a good example of amutable struct#29454: better example for mutable structIterators.flattenfor empty tuple #29112getpropertyandsetproperty!#29570 - basedocs: add 'See also' forgetpropertyandsetproperty!triureturns wrong matrix whenM<Nandk<0#29711: triu! for m > n=part of--projectis optional. Add to regular Julia docs as well. #29731 - Mention that the=part of--projectis optional. Add to regular Julia docs as well.make docsdoesn't copy _build/html for out of tree builds #29757.require(pkgid, ...)instead of relative require #29770 - Userequire(pkgid, ...)instead of relative requireNon-merged PRs with backport label: