-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPL: Handle message from complete_methods!
when max methods is hit
#57138
Merged
IanButterworth
merged 1 commit into
JuliaLang:master
from
IanButterworth:ib/repl_completion_fix
Jan 23, 2025
Merged
REPL: Handle message from complete_methods!
when max methods is hit
#57138
IanButterworth
merged 1 commit into
JuliaLang:master
from
IanButterworth:ib/repl_completion_fix
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got this problem on 1.11.3 when I type
and hit This PR fixed it. |
Looks like this might also fix #57127? I'm not able to verify myself at the moment, but it's the same error. |
xal-0
pushed a commit
to xal-0/julia
that referenced
this pull request
Jan 24, 2025
Do we have a regression test for this already? |
No, I didn't immediately see a way to. It may not be complicated. |
A systematic reproducer for me is for example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears #56963 wasn't a proper fix (although curiously it did appear to work #56963 (comment))
Reported on 1.11.3 https://discourse.julialang.org/t/sympy-makes-repl-to-stuck/124814/11