contrib: add --relative-rpath option to juliac.jl
#57199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change the function arguments to expose the `rpath` via a separate function call, if desired.
Also avoid calling Julia as a separate process just to query cflags, etc. preferring to import `julia-config.jl` as a module. Co-authored-by: Gabriel Baraldi <[email protected]>
topolarity
added
the
trimming
ararslan
reviewed
Feb 1, 2025
| if relative | ||
| if Sys.isapple() | ||
| return "-Wl,-rpath,'@loader_path/julia/' -Wl,-rpath,'@loader_path/'" | ||
| elseif Sys.islinux() |
There was a problem hiding this comment.
Seems like this should be Sys.isunix() instead of Sys.islinux()? It's not Linux-specific AFAICT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is useful when you'd like to deploy the generated library / executable across machines. This will tell the linker to look for the required libraries (
libjulia*.so,libopenblas, etc.) in an adjacentjulia/directory.We'll eventually use PackageCompiler to help bundle all the required libraries together, but for now this at least gets the lookup setup correctly in the created
.so/ binary.