CSL_jll: Fix libatomic path for FreeBSD
#57811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
approved these changes
Mar 18, 2025
giordano
reviewed
Mar 18, 2025
Comment on lines
9
to
11
| if !Sys.isfreebsd() | ||
| export libatomic | ||
| end |
There was a problem hiding this comment.
As I already said in #57808 (comment), I'm confused: libatomic is in https://github.com/JuliaBinaryWrappers/CompilerSupportLibraries_jll.jl/releases/download/CompilerSupportLibraries-v1.3.1%2B0/CompilerSupportLibraries.v1.3.1.x86_64-unknown-freebsd-libgfortran5.tar.gz. I'm not convinced this the right solution, feels to me like libatomic is getting lost.
There was a problem hiding this comment.
Hard-coding the wrong soname would do that:
libatomic.so.3, not libatomic.so.1
There was a problem hiding this comment.
Thanks for pointing that out @giordano , I think you're right.
This is required to avoid introducing a name / binding in the Module without a corresponding definition.
topolarity
force-pushed
the
ct/fix-freebsd-jll
branch
from
b5ac01a to
0244c96
Compare
topolarity
changed the title
libatomiclibatomic path for FreeBSD
topolarity
added
backport 1.12
|
Yes, when manually putting these files together, I must have searched for the presence of |
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to avoid introducing a name / binding in the Module without a corresponding definition.
Resolves #57808