Update deploy.yml to remove problematic minifier step #2013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minifier that Franklin leans on is buggy and, in any case, github pages optimises stuff for us so it's not needed.
In the context of #2006, it will help to disable it to see the generated HTML more clearly.
impact can be assessed here: https://github.com/JuliaLang/www.julialang.org/tree/gh-preview/previews/PR2013 where everything is generated properly and e.g. the
index.html
is not garbled anymore (and does actually have a closing html tag) https://github.com/JuliaLang/www.julialang.org/blob/gh-preview/previews/PR2013/index.html