Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy.yml to remove problematic minifier step #2013

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

tlienart
Copy link
Contributor

@tlienart tlienart commented Jan 11, 2024

The minifier that Franklin leans on is buggy and, in any case, github pages optimises stuff for us so it's not needed.

In the context of #2006, it will help to disable it to see the generated HTML more clearly.

impact can be assessed here: https://github.com/JuliaLang/www.julialang.org/tree/gh-preview/previews/PR2013 where everything is generated properly and e.g. the index.html is not garbled anymore (and does actually have a closing html tag) https://github.com/JuliaLang/www.julialang.org/blob/gh-preview/previews/PR2013/index.html

The minifier that Franklin leans on is buggy and, in any case, github pages optimises stuff for us so it's not needed.

In the context of #2006, it will help to disable it to see the generated HTML more clearly.
Copy link

Once the build has completed, you can preview your PR at this URL: https://julialang.netlify.app/previews/PR2013/ in ~15 minutes

Copy link
Member

@LilithHafner LilithHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping minification does have a small performance impact, even with gzip. However, I find the justification here and in tlienart/Franklin.jl#836 and #2006 (comment) to be worth that performance cost.

curl https://julialang.org/ | wc -c
39252 characters
3083 bytes sent
47404 bytes received

curl https://julialang.netlify.app/previews/pr2013/ | wc -c
47558 characters (+21%)
3773 bytes sent (+22%)
56056 bytes received (+18%)

When using the --compressed flag,

curl --compressed https://julialang.org/ | wc -c
39252 characters
2238 bytes sent
16771 bytes received

curl --compressed https://julialang.netlify.app/previews/pr2013/ | wc -c
47558 characters (+21%)
2584 bytes sent (+15%)
16886 bytes received (+0.7%)

@LilithHafner LilithHafner merged commit 1455b95 into main Jan 17, 2024
3 checks passed
@LilithHafner LilithHafner deleted the tl/rm-minifier branch January 17, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants