Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ducktyping #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ducktyping #34

wants to merge 2 commits into from

Conversation

pfitzseb
Copy link
Member

Ok, this may look a bit weird, but makes sure we support arbitrary objects (with the right fields) instead of only this package's Progress object.

The motivation for this is to add a nice progress frontend for VSCode while re-using ProgressLogging.asprogress and without forcing a specific version to be loaded (we're not loading this as a package in VSCode, only include the main file).

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #34 into master will decrease coverage by 0.56%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   69.04%   68.47%   -0.57%     
==========================================
  Files           1        1              
  Lines         168      184      +16     
==========================================
+ Hits          116      126      +10     
- Misses         52       58       +6     
Impacted Files Coverage Δ
src/ProgressLogging.jl 68.47% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10208bc...70ccc2b. Read the comment docs.

@pfitzseb pfitzseb requested a review from tkf September 14, 2020 16:21
@c42f
Copy link
Member

c42f commented Sep 23, 2020

This is a little confusing, given that I think you vendored most of ProgressLogging in julia-vscode over at julia-vscode/julia-vscode#1579?

Overall if these kind of hacks are really required, it seems Logging itself is missing some key abstraction which lets frontends and backends interact cleanly (see also comments at julia-vscode/julia-vscode#1579 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants