Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OGB Hetero-Graphs #140

Merged
merged 14 commits into from
Jun 19, 2022
Merged

Conversation

Dsantra92
Copy link
Collaborator

Handling Hetero Graphs in OGBDatasets.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #140 (55291f0) into master (0fd7858) will increase coverage by 9.65%.
The diff coverage is 76.43%.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   29.55%   39.21%   +9.65%     
==========================================
  Files          39       39              
  Lines        1543     1752     +209     
==========================================
+ Hits          456      687     +231     
+ Misses       1087     1065      -22     
Impacted Files Coverage Δ
src/graph.jl 50.00% <55.88%> (+8.33%) ⬆️
src/datasets/graphs/ogbdataset.jl 57.57% <80.89%> (+56.36%) ⬆️
src/abstract_datasets.jl 22.58% <0.00%> (-0.76%) ⬇️
src/datasets/vision/cifar10.jl 2.40% <0.00%> (-0.03%) ⬇️
src/datasets/graphs/planetoid.jl 100.00% <0.00%> (ø)
...rc/datasets/vision/cifar10_reader/CIFAR10Reader.jl 0.00% <0.00%> (ø)
.../datasets/vision/cifar100_reader/CIFAR100Reader.jl 0.00% <0.00%> (ø)
src/datasets/text/udenglish.jl 56.86% <0.00%> (+0.86%) ⬆️
src/datasets/vision/mnist_reader/readimages.jl 56.66% <0.00%> (+1.49%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fd7858...55291f0. Read the comment docs.

@CarloLucibello
Copy link
Member

Related to #139

@CarloLucibello
Copy link
Member

what's the status of this? on which specific ogb dataset are you testing?

@CarloLucibello CarloLucibello changed the title Supoprt for OGB Hetero-Graphs Support for OGB Hetero-Graphs Jun 10, 2022
@Dsantra92
Copy link
Collaborator Author

Testing it on ogbn-mag. Edge data section and docs is left. Completing by EOD.

@Dsantra92
Copy link
Collaborator Author

Not adding training indexes in this pr. Training splits will be handled as per the torch issue. We also need more documentation for HeteroGraphs (and maybe a tutorial). Not sure why docs are failing :)

@Dsantra92 Dsantra92 marked this pull request as ready for review June 14, 2022 20:01
@Dsantra92 Dsantra92 requested a review from CarloLucibello June 14, 2022 20:01
@CarloLucibello
Copy link
Member

Is ogbn-mag big? can we add it to the test set? If not in the CI tests we should at least add it to the local tests

@Dsantra92
Copy link
Collaborator Author

Is ogbn-mag big? can we add it to the test set? If not in the CI tests we should at least add it to the local tests

Yes, it might just be big enough to fail the CI. Let's test if the CI breaks, and then fix it.

@Dsantra92 Dsantra92 requested a review from CarloLucibello June 16, 2022 22:16
@CarloLucibello
Copy link
Member

node_data should be such that node_data[node_type] is a dict or a named tuples. Similar applies to edge_data.

@CarloLucibello CarloLucibello merged commit 43b6262 into JuliaML:master Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants