Update for BoundaryValueDiffEq v5 (#672)

* Update for BoundaryValueDiffEq v5 * Add news entry and bump version
JuliaManifolds · Oct 28, 2023 · ab49d04 · ab49d04 · mateuszbaran · Oct 28, 2023
1 parent cdf3f6c
commit ab49d04
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 12 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.9.3] - 2023-10-28
+
+### Added
+
+- Support for `BoundaryValueDiffEq` v5.
+
 ## [0.9.2] - 2023-10-27
 
 ### Added

diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Manifolds"
 uuid = "1cead3c2-87b3-11e9-0ccd-23c62b72b94e"
 authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
-version = "0.9.2"
+version = "0.9.3"
 
 [deps]
 Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
@@ -42,7 +42,7 @@ ManifoldsRecipesBaseExt = ["Colors", "RecipesBase"]
 ManifoldsTestExt = "Test"
 
 [compat]
-BoundaryValueDiffEq = "4"
+BoundaryValueDiffEq = "4, 5"
 Colors = "0.12"
 Distributions = "0.22.6, 0.23, 0.24, 0.25"
 Einsum = "0.4"

diff --git a/ext/ManifoldsBoundaryValueDiffEqExt.jl b/ext/ManifoldsBoundaryValueDiffEqExt.jl
@@ -39,7 +39,7 @@ end
         A::AbstractAtlas,
         i;
         solver=MIRK4(),
-        dt=0.05,
+        dt::Real=0.05,
         kwargs...,
     )
 
@@ -55,22 +55,18 @@ function solve_chart_log_bvp(
     A::AbstractAtlas,
     i;
     solver=MIRK4(),
-    dt=0.05,
+    dt::Real=0.05,
     kwargs...,
 )
     tspan = (0.0, 1.0)
     function bc1!(residual, u, p, t)
         mid = div(length(u[1]), 2)
         residual[1:mid] = u[1][1:mid] - a1
-        return residual[(mid + 1):end] = u[end][1:mid] - a2
+        residual[(mid + 1):end] = u[end][1:mid] - a2
+        return residual
     end
-    bvp1 = BVProblem(
-        chart_log_problem!,
-        bc1!,
-        (p, t) -> vcat(t * a1 + (1 - t) * a2, zero(a1)),
-        tspan,
-        (M, A, i),
-    )
+    u0 = [vcat(a1, zero(a1)), vcat(a2, zero(a1))]
+    bvp1 = BVProblem(chart_log_problem!, bc1!, u0, tspan, (M, A, i))
     sol1 = solve(bvp1, solver, dt=dt)
     return sol1
 end