Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more packages to weak dependencies #693

Closed
wants to merge 3 commits into from

Conversation

kellertuer
Copy link
Member

As discussed in #656, this is an idea to move two further packages to weak dependencies.

I am not saying we should necessarily do that, but it is something to discuss, and I for now just spent about an hour to reorganise the code. I am not yet sure the advantages outweigh the disadvantages here

This would be a breaking change

  • ArrayPartition will no longer be exported in Manifolds.jl
  • we currently loose some default implementations on product manifolds and groups (for RecursiveArrays) and a few random functions (for staticArrays) which could also be provided again as default without the package dependency for sure.

Before checking and adopting the tests I would like to discuss whether we actually want to do this, with the disadvantages above the question is, does the reduced loading time make this worth the change?

@kellertuer kellertuer added this to the v0.10.0 milestone Dec 15, 2023
@mateuszbaran mateuszbaran mentioned this pull request Jan 3, 2024
12 tasks
@mateuszbaran
Copy link
Member

I've taken a look at this now and I think removing StaticArrays as a dependency would be too annoying to pull off: too many methods use it internally for speed. RecursiveArrayTools, on the other hand, should be doable without major issues. Another dependency I'd prefer to have as a weak one is Distributions.jl.

I expect to have enough free time in August to push for a breaking release containing transition to weak dependencies + Oliver's PR (with polishing). What do you think?

@kellertuer
Copy link
Member Author

Yes, now that I noticed that Oliviers PR is breaking, we could combine that with this PR and check a bit what else to break since we are at it ;)

Thanks for looking into it.

@kellertuer
Copy link
Member Author

We could for example also do #701 then. That should even be a quite short PR.

@mateuszbaran
Copy link
Member

Yes, #701 could also be done, or any other quick and breaking thing we intended to do.

@kellertuer kellertuer mentioned this pull request Aug 3, 2024
8 tasks
@mateuszbaran
Copy link
Member

#732 is now merged and supersedes this PR so we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making RecursiveArrayTools and StaticArrays weak dependencies
2 participants