Move more packages to weak dependencies #693
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #656, this is an idea to move two further packages to weak dependencies.
I am not saying we should necessarily do that, but it is something to discuss, and I for now just spent about an hour to reorganise the code. I am not yet sure the advantages outweigh the disadvantages here
This would be a breaking change
ArrayPartition
will no longer be exported in Manifolds.jlBefore checking and adopting the tests I would like to discuss whether we actually want to do this, with the disadvantages above the question is, does the reduced loading time make this worth the change?