Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SizedArray for non-isbits types #61

Merged
merged 3 commits into from
Feb 25, 2024
Merged

use SizedArray for non-isbits types #61

merged 3 commits into from
Feb 25, 2024

Conversation

araujoms
Copy link
Contributor

Fixes #60

I've also updated the compat to demand StaticArrays to be at least 1.6.4, and added a couple of tests.

As expected, the benchmarks were indistinguishable. I've timed with the following code, copied from runtests.jl:

    @benchmark hcubature(x -> cos(x[1]), (0,), (1,))
    @benchmark hcubature(x -> cos(x[1])*cos(x[2]), [0,0], [1,1])
    f(x) = sin(x[1] + 3*sin(2*x[2] + 4*sin(3*x[3])))
    @benchmark hcubature(f, (0,0,0),(3,3,3), rtol=1e-6)

Got 89.942 ns, 5.648 μs, and 67.489 ms in the old version, and 85.637 ns, 5.662 μs, and 66.269 ms in the new version.

@araujoms
Copy link
Contributor Author

As it turns out StaticArrays 1.6.4 requires Julia 1.6, so CI fails with Julia 1.0.

@stevengj
Copy link
Member

Feel free to change the Project.toml to list julia 1.6, and change the CI.yml to test on 1.6 rather than 1.0.

@araujoms
Copy link
Contributor Author

Ok, now everything passes. I didn't want to change such a fundamental thing without your blessing.

Project.toml Show resolved Hide resolved
@stevengj stevengj merged commit 0e8470d into JuliaMath:master Feb 25, 2024
8 checks passed
@araujoms
Copy link
Contributor Author

Thanks a lot for you responsiveness and guidance.

@araujoms araujoms deleted the bigfloat branch February 25, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors with BigFloat boundaries
3 participants