add more inverses #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
===========================================
+ Coverage 97.14% 100.00% +2.85%
===========================================
Files 3 3
Lines 35 65 +30
===========================================
+ Hits 34 65 +31
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
|
I have been thinking about adding inverses like inverse(f::Base.Fix1{typeof(*)}) = ...
...
inverse(f::Base.Fix2{typeof(+)}) = ...myself, since they enable inverses of affine transformations. How do you see this @devmotion ? |
oschulz
reviewed
Jun 5, 2022
Seems reasonable. |
|
Thanks @aplavin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #12.
As I understand, all functions other than
^andlogare complete inverses on the whole available domain. Power and log inverses are implemented with separate functions to preserve proper domains, same approach assqrt <-> square.