Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invpow and invlog domains #23

Merged
merged 5 commits into from
Sep 26, 2022
Merged

fix invpow and invlog domains #23

merged 5 commits into from
Sep 26, 2022

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Aug 17, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (42139b3) compared to base (34c1adf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           74        89   +15     
=========================================
+ Hits            74        89   +15     
Impacted Files Coverage Δ
src/functions.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oschulz oschulz self-requested a review August 18, 2022 17:31
Copy link
Collaborator

@oschulz oschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oschulz
Copy link
Collaborator

oschulz commented Aug 18, 2022

Any objections, @devmotion ?

test/test_inverse.jl Outdated Show resolved Hide resolved
test/test_inverse.jl Outdated Show resolved Hide resolved
test/test_inverse.jl Outdated Show resolved Hide resolved
@aplavin
Copy link
Contributor Author

aplavin commented Sep 15, 2022

bump

@oschulz
Copy link
Collaborator

oschulz commented Sep 15, 2022

bump

@devmotion ?

src/functions.jl Outdated Show resolved Hide resolved
src/functions.jl Outdated Show resolved Hide resolved
src/functions.jl Outdated Show resolved Hide resolved
test/test_inverse.jl Outdated Show resolved Hide resolved
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. The only thing I noticed is that it seems one line is not covered by the tests. Could you add a test for it?

src/functions.jl Show resolved Hide resolved
@aplavin
Copy link
Contributor Author

aplavin commented Sep 26, 2022

Indeed! Splitting conditions into separate lines turned out to be helpful to catch this.

@oschulz oschulz merged commit 0e4a682 into JuliaMath:master Sep 26, 2022
@oschulz
Copy link
Collaborator

oschulz commented Sep 26, 2022

Thanks @aplavin !

Since it looks like we're converging on #24 and #25 as well, I'll hold of with a release, Ok?

@aplavin aplavin deleted the patch-1 branch January 11, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants