Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hyperbolic functions #47

Merged
merged 3 commits into from
Apr 25, 2024
Merged

add hyperbolic functions #47

merged 3 commits into from
Apr 25, 2024

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Apr 24, 2024

Unlike circular functions, these are invertible

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (5d998dc) to head (bac50cc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   99.22%   99.27%   +0.04%     
==========================================
  Files           6        6              
  Lines         129      137       +8     
==========================================
+ Hits          128      136       +8     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz
Copy link
Collaborator

oschulz commented Apr 25, 2024

Could you take a look at the Julia v1.0 test failures?

@oschulz
Copy link
Collaborator

oschulz commented Apr 25, 2024

Any objections from your side @devmotion ?

@oschulz
Copy link
Collaborator

oschulz commented Apr 25, 2024

@aplavin , want to add a version bump?

@aplavin
Copy link
Contributor Author

aplavin commented Apr 25, 2024

Nice!
Just for a bit of context – I wanted to make a plot with the asinh scale (it's like symlog, but smooth). Naturally, plotting needs the inverse for certain purposes.
With InverseFunctions it's very easy: the forward scale function is f = @o a * asinh(_/a), the inverse is inverse(f). No need to manually think of the proper multiplications/divisions in the inverse, this is a great piece of functionality!

Not too bad even without these inverses defined btw: f = @o a * setinverse(asinh, sinh)(_/a) always works.

@oschulz oschulz merged commit fbca280 into JuliaMath:master Apr 25, 2024
9 checks passed
@oschulz
Copy link
Collaborator

oschulz commented Apr 25, 2024

Nice @aplavin ! :-)

Ok, here we go: JuliaRegistries/General#105631

@aplavin aplavin deleted the patch-4 branch May 9, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants