Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support broadcasting #137

Merged
merged 5 commits into from
Feb 28, 2024
Merged

support broadcasting #137

merged 5 commits into from
Feb 28, 2024

Conversation

aplavin
Copy link
Member

@aplavin aplavin commented Feb 26, 2024 •
edited
Loading

Both in optics: @o first.(_) .+ 1, and in set (ref #75): @set a[1:2] .+= 5.

@aplavin aplavin requested a review from jw3126 February 28, 2024 02:39
jw3126
jw3126 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@jw3126 jw3126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I expected broadcasting to be nightmare but implementation looks simple and elegant!

@aplavin
Copy link
Member Author

aplavin commented Feb 28, 2024

There is a pain point with very different parsing of f.(a, b) and .+(a, b), but otherwise it wasn't a major problem indeed.

@aplavin aplavin merged commit 21d2e02 into JuliaObjects:master Feb 28, 2024
6 of 8 checks passed
@aplavin aplavin deleted the broadcast branch February 28, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jw3126 jw3126 jw3126 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aplavin @jw3126