Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weakdeps tryout #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Weakdeps tryout #171

wants to merge 1 commit into from

Conversation

aplavin
Copy link
Member

@aplavin aplavin commented Sep 13, 2024

Shouldn't be merged for now – demonstrates stdlib weakdeps issues.

@aplavin aplavin marked this pull request as draft September 13, 2024 12:41
@aplavin
Copy link
Member Author

aplavin commented Sep 13, 2024

If @devmotion or others with a better understanding of weakdeps can resolve these warnings you see in CI, they are welcome!

@aplavin
Copy link
Member Author

aplavin commented Dec 24, 2024

Not sure from which side (Julia or packages), but those weakdeps issues are somehow getting resolved: new CI runs show no warnings or errors about them without any changes here.
The only remaining strange thing is the type instability in getall on Julia 1.6. Behavior on that version shouldn't be affected by this PR at all...

@aplavin
Copy link
Member Author

aplavin commented Dec 25, 2024

Oh, it was just a wrong version!
Now indeed we have no errors/warnings with this PR and can finally make the last dep weak. Anyone against this?

@aplavin aplavin marked this pull request as ready for review December 25, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant