Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trivial @accessor functions #187

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

aplavin
Copy link
Member

@aplavin aplavin commented Dec 22, 2024

@accessor f(x) = x triggered some edgecase in parsing, fixed now.

Can be reproduced with regular @optic macros without @accessor, but probably noone write optics like this:

# worked before as well:
julia> @optic begin
       _ + 1
       end
(::Base.Fix2{typeof(+), Int64}) (generic function with 1 method)

# threw an error before:
julia> @optic begin
       _
       end
identity (generic function with 1 method)

@jw3126 jw3126 merged commit 2675bd3 into JuliaObjects:master Dec 24, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants