Replace LegacyGridWorld with SimpleGridWorld #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsunberg
reviewed
Feb 3, 2022
|
@BoZenKhaa thanks! Looks good! It is funny to see how old those scripts are. |
|
Great, thanks! I think it's ok to close the related issues too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced LegacyGridWorld with SimpleGridWorld in tests and benchmarks. For the most part, I simple replaced the names of the corresponding structures.
This seems to mostly work, with few exceptions:
in the TestVisualization.ipynb, its no longer possible to mark terminal states in the tree, since MCTS.node_tag does not take the mdp parameter needed for isterminal(mdp, state). Previously, this worked since LegacyGridWorld state had field
done, accessible from anywhere.There is a test in runtest.jl that I believe used to tests whether a transition from terminal state throws an error. That doesn't happen with SimpleGridWorld. I have commented the test out for now.
I can't get ProfileView.jl to run on my headles server where I use Julia, so I have commented it's use out in the bench scripts.
Also, I have removed the REQUIRE file and replaced it with Project.toml for the test directory and updated the .gitignore correspondingly.
This should address these issues: #57, #59, and possibly #62