Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use invokelatest for listenpkg #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

use invokelatest for listenpkg #81

wants to merge 3 commits into from

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Feb 17, 2020 •
edited
Loading

fixes #80

@timholy
Copy link
Member

timholy commented Feb 17, 2020

Any chance you can add a test?

@vchuravy vchuravy mentioned this pull request Feb 19, 2020
Closed
@vchuravy
Copy link
Member Author

While creating a test, I figured out that the actual issue was me nesting @init.
That causes false behaviour in the case where the require dependency is loaded after.
Since we only will run __init__ once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading dependency before loading package leads to worldage issue
2 participants
@vchuravy @timholy