[Reactant] Build for aarch64-linux with CUDA #10313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/reactant-cuda-aarch64
branch
from
9244126 to
97b95a7
Compare
giordano
force-pushed
the
mg/reactant-cuda-aarch64
branch
5 times, most recently
from
e3d0b6a to
633fa57
Compare
Spoiler: local build is successful, but we still need to do reorganise some bits.
giordano
force-pushed
the
mg/reactant-cuda-aarch64
branch
from
af7b742 to
93dd806
Compare
|
https://buildkite.com/julialang/yggdrasil/builds/16785#0194a869-1348-441d-a6a6-80a72a8b2a2c/687-1725 Sigh. I've seen this error before, but can't remember where. Edit: that's where I saw it: #10190 (comment) |
|
Doing a quick search in https://github.com/roblabla/MacOSX-SDKs I think that means we need to use at least the 13.3 SDK: % grep -r 'hardware_destructive_interference_size' .
./MacOSX13.3.sdk/usr/include/c++/v1/new:inline constexpr size_t hardware_destructive_interference_size = __GCC_DESTRUCTIVE_SIZE;
./MacOSX14.0.sdk/usr/include/c++/v1/new:inline constexpr size_t hardware_destructive_interference_size = __GCC_DESTRUCTIVE_SIZE;
./MacOSX14.2.sdk/usr/include/c++/v1/new:inline constexpr size_t hardware_destructive_interference_size = __GCC_DESTRUCTIVE_SIZE;
./MacOSX14.4.sdk/usr/include/c++/v1/new:inline constexpr size_t hardware_destructive_interference_size = __GCC_DESTRUCTIVE_SIZE;
./MacOSX14.5.sdk/usr/include/c++/v1/new:inline constexpr size_t hardware_destructive_interference_size = __GCC_DESTRUCTIVE_SIZE;
./MacOSX15.0.sdk/usr/include/c++/v1/new:inline constexpr size_t hardware_destructive_interference_size = __GCC_DESTRUCTIVE_SIZE;I hope that's enough..... |
|
Small progress, with the 13.3 SDK I get to a different error: Edit: git bisect points to openxla/xla@9d95a71. Edit: this was fixed by openxla/xla#21768, we were building on top of the previous commit 🥲 |
giordano
force-pushed
the
mg/reactant-cuda-aarch64
branch
from
452d696 to
38aeca6
Compare
|
https://buildkite.com/julialang/yggdrasil/builds/16793#0194a97d-d9de-402f-99e3-30ce6338f7b7/6-20170 @wsmoses this is your stuff, it was working before EnzymeAD/Reactant.jl@ |
wsmoses
reviewed
Jan 27, 2025
R/Reactant/build_tarballs.jl
Outdated
| # Compiling LLVM components within XLA requires macOS SDK 10.14. | ||
| pushd $WORKSPACE/srcdir/MacOSX10.*.sdk | ||
| # But then we need 13.3 for another `std::hardware_destructive_interference_size`: | ||
| # <https://github.com/JuliaPackaging/Yggdrasil/pull/10313#issuecomment-2616125018>. |
There was a problem hiding this comment.
@giordano we were just removing hw interference size: https://github.com/EnzymeAD/Reactant.jl/blob/fd60aad440379a9b04a0164f34cbd65cd679ed89/deps/ReactantExtra/WORKSPACE#L57
This reverts commit 909a78c.
Closed
giordano
force-pushed
the
mg/reactant-cuda-aarch64
branch
from
76d6cb8 to
b189eda
Compare
|
🚀 |
1 similar comment
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only to save my progress along the way, nothing works at the moment.