backward module #753
Merged
backward module #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
force-pushed
the
mforets/backward
branch
from
ee0d163 to
20c9963
Compare
added 2 commits
January 12, 2024 16:54
mforets
force-pushed
the
mforets/backward
branch
from
20c9963 to
e5dfc0f
Compare
|
still some issues with docs build.. |
|
idk why the docs is failing really, since @schillic should we make the docs build less strict? |
schillic
force-pushed
the
mforets/backward
branch
from
e9e6ad5 to
35fbb06
Compare
|
I fixed the problem. I also removed your last commit because it was not needed. |
|
thanks! |
|
This is ready from my side. I plan to address more refactors in subsequent PRs. |
schillic
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.