Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#818 - Refactor TMJets algorithms #819

Merged
merged 2 commits into from
Apr 5, 2024
Merged

#818 - Refactor TMJets algorithms #819

merged 2 commits into from
Apr 5, 2024

Conversation

schillic
Copy link
Member

@schillic schillic commented Apr 5, 2024

Closes #818.

The second commit reverts back to TMJets21a in the README (the change in #808 was invalid because TMJets21b does not work, at least not with the default settings).

@schillic
Copy link
Member Author

schillic commented Apr 5, 2024

As a side note, the plot shown in the README

is much tighter than what we produce with the given code.

1

But this image lives on the web page, so it was probably obtained with tighter settings. Not sure if it is a good user experience if you want to reproduce the example and cannot...

@schillic schillic marked this pull request as ready for review April 5, 2024 19:45
@schillic schillic merged commit 25a4c48 into master Apr 5, 2024
6 checks passed
@schillic schillic deleted the schillic/818 branch April 5, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor TMJets algorithms
1 participant