Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devdocs: document that it's okay for Codecov to be red on PRs #483

Closed
wants to merge 26 commits into from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Dec 4, 2023

Follow-up to #477

DilumAluthge and others added 25 commits December 1, 2023 16:44
This is necessary because the `${{ matrix... }}` interpolations are not evaluated for skipped jobs
* add codecov threshold

to help with #477

* Update codecov.yml

* fix indentation

* Update codecov.yml
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5487c99) 99.49% compared to head (12c6a89) 99.49%.

Additional details and impacted files
@@               Coverage Diff                @@
##           dpa/merge-queue     #483   +/-   ##
================================================
  Coverage            99.49%   99.49%           
================================================
  Files                   12       12           
  Lines                  398      398           
================================================
  Hits                   396      396           
  Misses                   2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from dpa/merge-queue to master January 8, 2024 19:00
@DilumAluthge DilumAluthge deleted the dpa/devdocs branch January 11, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants