-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yank some versions of OptimizationBase #107391
Yank some versions of OptimizationBase #107391
Conversation
See https://github.com/JuliaRegistries/General?tab=readme-ov-file#when-is-yanking-a-release-appropriate:
|
What do you conclude from this? That yanking is indeed necessary here? |
Yeah based on what David has quoted above it does seem yanking is necessary so I am okay with this |
IMO based on the README yanking would be fine, but (if maintainers - and user? - prefer it) something like #107409 could be an alternative. |
Tbh I had just overlooked the part that you can retrospectively change the compat bounds. I don't quite get what errors can be expected mentioned there? |
I'm just wary (and I guess David too) because the syntax of compat bounds is slightly harder to get right than just |
Yank is fine given there are versions before and after. Thanks for going through with this, sorry it took awhile to get to reviewing. |
This PR yanks three consecutive versions of OptimizationBase (v0.0.6, v0.0.7, v1.0.0) because they incorrectly promised compatibility with ADTypes v1.
Question: is this necessary, or would a patch release be enough? My fear is that the patch release v0.0.8 is incompatible with v0.0.7, and so some people would not automatically get it (due to the double leading zero). Am I reading that correctly?
See also: