Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copulas.jl - retroactive compat bound tightening on TaylorSeries.jl #115345

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

lrnv
Copy link
Contributor

@lrnv lrnv commented Sep 17, 2024

Hey,

Following guidance from @BioTurboNick on slack and while #104849 is still pending, I try in this PR to retroactively tighten the lower bound on TaylorSeries.jl on recent versions of Copulas.jl : at the time, I did use a feature that was only available in TaylorSeries > 0.15 but kept the old compat bound...

These days, it results in issues such as lrnv/Copulas.jl#207 and lrnv/Copulas.jl#217. If these issues are usually solved by ]up or even ]up TaylorSeries, it is still anoying.

Warning: Although I have respected these docs of the compat file, I am not sure the fix I applied will be working correctly, and would appreciate some human taking the time to check it up before merging :)

Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Oct 18, 2024
@lrnv
Copy link
Contributor Author

lrnv commented Oct 18, 2024

I would like this to be manually merged. Explanation are in the top post. [noblock]

@BioTurboNick
Copy link
Contributor

I suggest pinging a maintainer specifically, possibly this is lost in the swamp of PRs.

@github-actions github-actions bot removed the stale label Oct 19, 2024
@ViralBShah
Copy link
Contributor

There's conflicts here holding back the merge.

@ViralBShah
Copy link
Contributor

@BioTurboNick Do you have commit access to this repo?

@lrnv
Copy link
Contributor Author

lrnv commented Oct 21, 2024

Conflicts solved. They appeard because I released another version while this PR was waiting, should be good to go now. [noblock]

Errr scratch that, not working.

@BioTurboNick
Copy link
Contributor

@BioTurboNick Do you have commit access to this repo?

Nope, just being helpful :-)

@lrnv
Copy link
Contributor Author

lrnv commented Oct 21, 2024

@ViralBShah Okay this time should be good to go. [noblock]

@ViralBShah ViralBShah merged commit 2a7acdd into JuliaRegistries:master Oct 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants