Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: add compat for Statistics #68391

Closed
wants to merge 1 commit into from
Closed

WIP: add compat for Statistics #68391

wants to merge 1 commit into from

Conversation

KristofferC
Copy link
Member

No description provided.

@KristofferC KristofferC temporarily deployed to stopwatch September 16, 2022 07:45 Inactive
@KristofferC KristofferC mentioned this pull request Sep 16, 2022
Merged
@DilumAluthge DilumAluthge marked this pull request as draft September 16, 2022 23:47
@DilumAluthge
Copy link
Member

DilumAluthge commented Sep 16, 2022 •
edited
Loading

Just for reference, could you post the code used to generate this PR?

@nalimilan
Copy link
Contributor

Can we merge this? It seems required to run Nanosoldier on JuliaStats/Statistics.jl#128 and then merge it.

@KristofferC KristofferC reopened this Oct 10, 2022
@KristofferC KristofferC temporarily deployed to stopwatch October 10, 2022 10:14 Inactive
@KristofferC KristofferC temporarily deployed to stopwatch October 10, 2022 10:14 Inactive
@KristofferC
Copy link
Member Author

Just for reference, could you post the code used to generate this PR?

Using https://github.com/KristofferC/StdlibRegistryCompatUpdater:

julia> pkg = (Base.UUID("10745b16-79ce-11e8-11f9-7d13ad32a3b2") => "Statistics")

julia> StdlibRegistryCompatUpdater.update_compat_for_stdlib(pkg)

Can we merge this? It seems required to run Nanosoldier on JuliaStats/Statistics.jl#128 and then merge it.

Should be fine now.,

@KristofferC KristofferC reopened this Oct 10, 2022
@KristofferC KristofferC temporarily deployed to stopwatch October 10, 2022 11:07 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Nov 9, 2022
@github-actions
Copy link
Contributor

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

@github-actions github-actions bot closed this Nov 17, 2022
@github-actions github-actions bot deleted the kc/statistics_compat branch November 17, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compat fix do not merge stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KristofferC @DilumAluthge @nalimilan