Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Cap RecursiveArrayToolsVersion for existing versions of Symbolics" #93513

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

KristofferC
Copy link
Member

Reverts #93498

This PR was buggy

@KristofferC KristofferC temporarily deployed to stopwatch October 16, 2023 18:24 — with GitHub Actions Inactive
@DilumAluthge
Copy link
Member

How did our CI not catch this? RegistryCI has a test to make sure that every entry in Compat also shows up in Deps.

@KristofferC KristofferC merged commit 3a06016 into master Oct 16, 2023
10 checks passed
@KristofferC KristofferC deleted the revert-93498-patch-1 branch October 16, 2023 18:31
@KristofferC
Copy link
Member Author

RegistryCI has a test to make sure that every entry in Compat also shows up in Deps.

I guess it isn't accurate enough. For every version, every compat entry needs to have a corresponding deps entry (for that version). This is clearly not the case here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants