Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguities and test quality with Aqua #1041

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Fix ambiguities and test quality with Aqua #1041

merged 2 commits into from
Aug 18, 2023

Conversation

Affie
Copy link
Member

@Affie Affie commented Aug 18, 2023

FIY @dehann, Aqua.jl turned out to be quite handy in cleaning up code.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1041 (6ae286e) into master (acd03da) will decrease coverage by 10.65%.
The diff coverage is 20.00%.

@@             Coverage Diff             @@
##           master    #1041       +/-   ##
===========================================
- Coverage   77.46%   66.81%   -10.65%     
===========================================
  Files          26       26               
  Lines        2285     2287        +2     
===========================================
- Hits         1770     1528      -242     
- Misses        515      759      +244     
Files Changed Coverage Δ
src/DistributedFactorGraphs.jl 100.00% <ø> (ø)
src/DataBlobs/services/BlobStores.jl 64.34% <20.00%> (-1.54%) ⬇️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie Affie merged commit bde8a13 into master Aug 18, 2023
4 of 6 checks passed
@Affie Affie deleted the 23Q3/maint/aqua branch August 18, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant