fix tests for JL 1.10 #1042
Merged
fix tests for JL 1.10 #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -151,7 +153,7 @@ end | |||
| @test !isPrior(dfg, :abf1) # f1 is not a prior | |||
| @test lsfPriors(dfg) == [] | |||
| #FIXME don't know what it is supposed to do | |||
| @test_broken lsfTypes(dfg) | |||
| @test 0 < length( lsfTypes(dfg) ) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test 0 < length( lsfTypes(dfg) ) | |
| @test 0 < length(lsfTypes(dfg)) |
| @@ -161,7 +163,7 @@ end | |||
| @test getVariableType(dfg, :a) isa Position{1} | |||
|
|
|||
| #TODO what is lsTypes supposed to return? | |||
| @test_broken lsTypes(dfg) | |||
| @test 0 < length( lsTypes(dfg) ) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test 0 < length( lsTypes(dfg) ) | |
| @test 0 < length(lsTypes(dfg)) |
Codecov Report
@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
+ Coverage 77.51% 77.60% +0.08%
==========================================
Files 26 26
Lines 2273 2282 +9
==========================================
+ Hits 1762 1771 +9
Misses 511 511 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This is not really fixing the test. It should check for the returned values specifically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.