Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cf.manifold for CalcFactor #1783

Merged
merged 1 commit into from
Oct 12, 2023
Merged

cf.manifold for CalcFactor #1783

merged 1 commit into from
Oct 12, 2023

Conversation

dehann
Copy link
Member

@dehann dehann commented Oct 12, 2023

No description provided.

@dehann dehann requested a review from Affie October 12, 2023 07:59
@dehann dehann added this to the v0.34.2 milestone Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1783 (22c541f) into master (4c04074) will decrease coverage by 23.19%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #1783       +/-   ##
===========================================
- Coverage   75.04%   51.85%   -23.19%     
===========================================
  Files          82       80        -2     
  Lines        5986     5965       -21     
===========================================
- Hits         4492     3093     -1399     
- Misses       1494     2872     +1378     
Files Coverage Δ
src/entities/CalcFactor.jl 66.66% <100.00%> (+8.33%) ⬆️

... and 51 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Affie Affie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the performance of overloading getproperty, but this will be temporary.

@dehann dehann merged commit f1707b0 into master Oct 12, 2023
5 of 7 checks passed
@Affie Affie modified the milestones: v0.34.2, v0.35.0 Oct 17, 2023
@dehann dehann deleted the 23Q4/enh/manicf branch November 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants