Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check all matches agains threshold #27

Merged
merged 1 commit into from
Apr 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ext/services/OpenCVFeatures.jl
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ function goodFeaturesToTrackORB(
return kp_, des
end

function getPoseSIFT(imgA, imgB, K; mask=nothing)
function getPoseSIFT(imgA, imgB, K; mask=nothing, distthreshold=100)
# Initiate SIFT detector
sift = cv.SIFT_create()
# sift = cv.ORB_create()
Expand All @@ -148,10 +148,10 @@ function getPoseSIFT(imgA, imgB, K; mask=nothing)
# Apply ratio test
good = []
for mat in matches
m = mat[1]
n = mat[2]
if m.distance < 0.75 * n.distance
push!(good, (distance=m.distance, queryIdx=m.queryIdx+1, trainIdx=m.trainIdx+1))
for m in mat
if m.distance < distthreshold
push!(good, (distance=m.distance, queryIdx=m.queryIdx+1, trainIdx=m.trainIdx+1))
end
end
end

Expand Down
Loading