Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue with the adjoint in JOSS #810

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Fix the issue with the adjoint in JOSS #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acefe34
Fix the issue with the adjoint in JOSS
amontoison Sep 22, 2023
96c2d32
Update example2.jl
amontoison Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,3 @@ steps:
Pkg.instantiate()
include("paper/example2/example2.jl")'
timeout_in_minutes: 30

- label: "CPUs -- StaticArrays.jl"
plugins:
- JuliaCI/julia#v1:
version: 1.9
agents:
queue: "juliaecosystem"
command: |
julia --color=yes --project -e '
using Pkg
Pkg.add("StaticArrays")
Pkg.instantiate()
include("test/test_extensions.jl")'
timeout_in_minutes: 30
6 changes: 4 additions & 2 deletions paper/example2/example2.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ if CUDA.functional()

# Solve Py = x
function ldiv_ic0!(P, x, y, z)
ldiv!(z, LowerTriangular(P), x) # Forward substitution with L
ldiv!(y, LowerTriangular(P)', z) # Backward substitution with Lᴴ
L = LowerTriangular(P)
Lᴴ = adjoint(L)
ldiv!(z, L, x) # Forward substitution with L
ldiv!(y, Lᴴ, z) # Backward substitution with Lᴴ
return y
end

Expand Down
6 changes: 4 additions & 2 deletions paper/paper.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,10 @@ if CUDA.functional()

# Solve Py = x
function ldiv_ic0!(P, x, y, z)
ldiv!(z, LowerTriangular(P), x) # Forward substitution with L
ldiv!(y, LowerTriangular(P)', z) # Backward substitution with Lᴴ
L = LowerTriangular(P)
Lᴴ = adjoint(L)
ldiv!(z, L, x) # Forward substitution with L
ldiv!(y, Lᴴ, z) # Backward substitution with Lᴴ
return y
end

Expand Down