Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type inference of extract_parameters #890

Merged

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Oct 13, 2024

@mosullivan93
Could you please confirm if, for a vector of Expr like the following:

def_kwargs_cg = (:(; M = I                     ),
                 :(; ldiv::Bool = false        ),
                 :(; radius::T = zero(T)       ),
                 :(; linesearch::Bool = false  ),
                 :(; atol::T = eps(T)         ),
                 :(; rtol::T = eps(T)         ),
                 :(; itmax::Int = 0            ),
                 :(; timemax::Float64 = Inf    ),
                 :(; verbose::Int = 0          ),
                 :(; history::Bool = false     ),
                 :(; callback = solver -> false),
                 :(; iostream::IO = kstdout    ))

Is it always the case that for each expression ex, the length of ex.args[1].args is equal to 1?
I want to improve the type inference of the function extract_parameters that you suggested a long time ago.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.93%. Comparing base (f5fbae9) to head (c594d57).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/krylov_utils.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
+ Coverage   94.43%   94.93%   +0.49%     
==========================================
  Files          44       44              
  Lines        8206     8206              
==========================================
+ Hits         7749     7790      +41     
+ Misses        457      416      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontoison amontoison merged commit cb0d23f into JuliaSmoothOptimizers:main Oct 13, 2024
31 of 32 checks passed
@amontoison amontoison deleted the extract_parameters_upgrade branch October 13, 2024 19:39
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
LinearSolve.jl
Percival.jl
RipQP.jl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant