Skip to content

Commit

Permalink
Match base julia error messages for hvcat
Browse files Browse the repository at this point in the history
  • Loading branch information
wsmoses committed Nov 29, 2024
1 parent c8dd8ad commit c2fcd7a
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions src/sparsevector.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1243,6 +1243,15 @@ function hvcat_internal(rows::Tuple{Vararg{Int}}, X1::_SparseConcatGroup, X::_Sp
if anysparse(X1) || anysparse(X...)
vcat(_hvcat_rows(rows, X1, X...)...)
else
# Needed to match error type with Base Julia. See https://github.com/JuliaLang/julia/pull/56543#issuecomment-2508637550
matrix_len = if length(rows) == 0
0

Check warning on line 1248 in src/sparsevector.jl

View check run for this annotation

Codecov / codecov/patch

src/sparsevector.jl#L1248

Added line #L1248 was not covered by tests
else
length(rows) * rows[1]
end
if matrix_len != 1 + length(X)
throw(ArgumentError("argument count does not match specified shape (expected $matrix_len, got $(1+length(X)))"))

Check warning on line 1253 in src/sparsevector.jl

View check run for this annotation

Codecov / codecov/patch

src/sparsevector.jl#L1253

Added line #L1253 was not covered by tests
end
Base.typed_hvcat(Base.promote_eltypeof(X1, X...), rows, X1, X...)
end
end
Expand Down

0 comments on commit c2fcd7a

Please sign in to comment.