-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports for Julia v1.10 #439
Conversation
@vtjnash Could you please review your recent cat-related commits and push those that are suitable for backport here? |
Ensures that Union{} is not part of the output possibilities after type-piracy of Base.cat methods. Refs JuliaLang/julia#50550 (cherry picked from commit c402d09)
This little gadget creates a closure over Type{T} instead of DataType. Fix JuliaLang/julia#50623 (cherry picked from commit 68afc6e)
The generic `cat` does more shape analysis, that typed_cat does not always do (before either may then dispatch to _cat_t), so we can make this faster by calling it instead. Secondly, we can make `issparse` non-recursive once it hits a base case where all trailing elements are the same. This makes it much better at handling large splat, since we do not need to check each recursively smaller type down to the base case using generic code, and just generate one const method specialized on the full length instead. Fix JuliaLang/julia#51011 (cherry picked from commit 4e6776a)
Codecov Report
@@ Coverage Diff @@
## release-1.10 #439 +/- ##
===============================================
Coverage ? 93.19%
===============================================
Files ? 12
Lines ? 7667
Branches ? 0
===============================================
Hits ? 7145
Misses ? 522
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Can #423 be backported? |
* Respect IOContext in printing column indices * Add docstring to ColumnIndices
Do we want to try to get these into Julia 1.10? |
Yes, definitely. We could merge now and then bump on Julia's release branch. |
In fact, how about backporting the docs commit? I think the changes there were (at the end) minimal and not version-dependent. |
* Adapt to Documenter v1
One backport we should do is SuiteSparse 7.2.1. The current version on 1.10 uses @Wimmerer 's branch of SuiteSparse, but all that has been upstreamed in an official release in 7.2.1, which is making its way through Yggdrasil etc. |
#438