Fix performance trap for sparse view multiplication #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
force-pushed
the
dk/colptr_view
branch
from
c2a3c9e to
3f51402
Compare
dkarrasch
force-pushed
the
dk/colptr_view
branch
from
3f51402 to
afa4be6
Compare
dkarrasch
changed the title
getcolptr for sparse matrix views
dkarrasch
force-pushed
the
dk/colptr_view
branch
from
5bf1704 to
4d15843
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
=======================================
Coverage 85.17% 85.17%
=======================================
Files 12 12
Lines 8865 8866 +1
=======================================
+ Hits 7551 7552 +1
Misses 1314 1314 ☔ View full report in Codecov by Sentry. |
|
There's an opportunity here to bikeshed about names of internal aliases... just in case things can be improved for more clarity. I was not very creative. |
rayegun
reviewed
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that for non-triangular sparse matrices,
getcolptr, which can be easily computed from the parent array, is not used. But all the otherget*functions don't require a unit range as the second slicing argumnet in column views, so the fast multiplication kernels also apply to that situation.Fixes #475.