Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added diagonal-sparse multiplication #564

Merged
merged 6 commits into from
Oct 29, 2024
Merged

added diagonal-sparse multiplication #564

merged 6 commits into from
Oct 29, 2024

Conversation

matbesancon
Copy link
Contributor

@matbesancon matbesancon commented Oct 11, 2024

Adds a specialization for the out-of-place multiplication of Diagonal * sparse-vector, otherwise the current version was O(n) instead of O(nnz)

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (313a04f) to head (eedb426).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   84.09%   84.16%   +0.07%     
==========================================
  Files          12       12              
  Lines        9102     9172      +70     
==========================================
+ Hits         7654     7720      +66     
- Misses       1448     1452       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matbesancon
Copy link
Contributor Author

@dkarrasch this should be good to go too

src/linalg.jl Outdated Show resolved Hide resolved
src/linalg.jl Outdated Show resolved Hide resolved
matbesancon and others added 2 commits October 24, 2024 18:10
Co-authored-by: Daniel Karrasch <[email protected]>
Co-authored-by: Daniel Karrasch <[email protected]>
@dkarrasch dkarrasch added merge me Merge when all tests are passing performance labels Oct 24, 2024
@matbesancon matbesancon requested a review from dkarrasch October 29, 2024 14:43
@dkarrasch dkarrasch merged commit 33491e0 into main Oct 29, 2024
12 checks passed
@dkarrasch dkarrasch deleted the diag-sparse-mul branch October 29, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Merge when all tests are passing performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants