-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added specialized method for 3-argument dot with diagonal matrix #565
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
+ Coverage 84.09% 84.13% +0.04%
==========================================
Files 12 12
Lines 9102 9159 +57
==========================================
+ Hits 7654 7706 +52
- Misses 1448 1453 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. The comments refer to both methods actually. As for the length checks, perhaps you could add tests for all mismatching cases?
Closes #563