Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 14333eae647464121150ae77d9f2dbe673aa244b to 1.10 #580

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

gbaraldi
Copy link

@gbaraldi gbaraldi commented Nov 12, 2024

Backport of #579

@ViralBShah
Copy link
Member

@dkarrasch Do these go on to release-1.10 or backports-release-1.10?

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (8c84b8c) to head (a906108).
Report is 1 commits behind head on release-1.10.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10     #580      +/-   ##
================================================
+ Coverage         92.64%   92.66%   +0.01%     
================================================
  Files                12       12              
  Lines              7670     7672       +2     
================================================
+ Hits               7106     7109       +3     
+ Misses              564      563       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkarrasch
Copy link
Member

backports-release-1.10 may have been deleted after merging, so if this is intended for a single commit, making a PR against release-1.10 directly should be fine. The other question is if we have a backports-release-1.10 PR open over at julialang, or we make a bump PR directly to release-1.10.

@KristofferC KristofferC merged commit c8dd8ad into JuliaSparse:release-1.10 Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants