RFC: Officially allow/document overriding distribution support type #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any concerns with this? |
|
Bumping this again. I'd like to keep moving forward with #634 but this is a blocker for it. |
|
Some of the fallbacks assume that the outcomes are in |
|
What do you mean by |
|
The natural numbers and zero
søn. 21. jan. 2018 kl. 00.15 skrev Gord Stephen <[email protected]>:
… What do you mean by N_0?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#699 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAe0qbK6KRX2k_smLTIPHVmD4ZOCTnGPks5tMnOdgaJpZM4RMAUu>
.
|
|
It would fix different problems to relax this assumption and allow moving on with things like #661 |
mschauer
approved these changes
Oct 25, 2018
|
@GordStephen this branch is still on Julia 0.6, could you rebase on master? |
matbesancon
approved these changes
Oct 25, 2018
GordStephen
force-pushed
the
gs/decouple-supportvalue-eltype
branch
from
dce5af4 to
1b72bbf
Compare
|
Ok, the branch is now rebased. |
|
Thanks, merging this in 24 hours if no objection. |
andreasnoack
approved these changes
Oct 26, 2018
|
thanks @GordStephen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes strict coupling between continuous/discrete distributions and support types, as discussed in #681.
No actual new code here, just an update to the the docs to flag the assumptions about support types of different distributions and the ability to override the defaults. The
eltype(::Type{<:ValueSupport})methods are unused and wouldn't be accurate anyways in the case of an override, so they're removed.This sets the stage for allowing discrete non-integer-support distributions (e.g. #634 and #661).