Use promote_type instead of promote_eltype in misc tests #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this has been wrong from the beginning but just happened to work until Julia 1.10.
There are failures on Julia 1.6 related to inference. I've identified the regression to come from version 0.3.18 of
HypergeometricFunctions
. It's not at all clear why it happens andBase.return_types
andcode_warntype
disagreesnot clear what we should do here.