Merge pull request #914 from JuliaSymbolics/myb/deadlock_fix

MultithreadedForm can cause deadlock

Project.toml

@@ -51,7 +51,7 @@ RecipesBase = "1.1"
 Reexport = "0.2, 1"
 ReferenceTests = "0.9"
 Requires = "1.1"
-RuntimeGeneratedFunctions = "=0.5.9"
+RuntimeGeneratedFunctions = "0.5.9"
 SciMLBase = "1.8"
 Setfield = "0.7, 0.8, 1"
 SpecialFunctions = "0.7, 0.8, 0.9, 0.10, 1.0, 2"

src/build_function.jl

@@ -264,9 +264,8 @@ function _build_function(target::JuliaTarget, rhss::AbstractArray, args...;
                        iip_config = (true, true),
                        parallel=nothing, cse = false, kwargs...)
 
-  if parallel == nothing && _nnz(rhss) >= 1000
-        parallel = ShardedForm() # by default switch for arrays longer than 1000 exprs
-    end
+    # We cannot switch to ShardedForm because it deadlocks with
+    # RuntimeGeneratedFunctions
     dargs = map((x) -> destructure_arg(x[2], !checkbounds,
                                   Symbol("ˍ₋arg$(x[1])")), enumerate([args...]))
     i = findfirst(x->x isa DestructuredArgs, dargs)

test/latexify_refs/integral1.txt

@@ -1,3 +1,3 @@
 \begin{equation}
-\mathrm{Integral(dx, 0..1)}\left( x \right)
+\int_{0}^{1)} dx x
 \end{equation}

test/latexify_refs/integral2.txt

@@ -1,3 +1,3 @@
 \begin{equation}
-\mathrm{Integral(dx, -Inf..Inf)}\left( \left( u\left( x \right) \right)^{2} \right)
+\int_{-\infty}^{\infty)} dx \left( u\left( x \right) \right)^{2}
 \end{equation}

test/latexify_refs/integral3.txt

@@ -1,3 +1,3 @@
 \begin{equation}
-\mathrm{Integral(dx, -z..u(x))}\left( x^{2} \right)
+\int_{ - z}^{u\left( x \right))} dx x^{2}
 \end{equation}