-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for rewrite hellper #1026
Tests for rewrite hellper #1026
Conversation
2d0e2fa
to
637b8e6
Compare
With some exceptions ("LuxCore extensions Test" and "Groebner extension Test", which should be unrelated to this), tests passes locally. I think CI can be activated for the PR now (@shashi). |
@@ -0,0 +1,134 @@ | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably move ModelingToolkit.fixedpoint_sub
here as well?
Missing a docs page. @YingboMa should review the implementation. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1026 +/- ##
==========================================
- Coverage 77.07% 76.25% -0.82%
==========================================
Files 32 34 +2
Lines 3533 3601 +68
==========================================
+ Hits 2723 2746 +23
- Misses 810 855 +45 ☔ View full report in Codecov by Sentry. |
I have added entries in the docs now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also makes some updates to the functions and adds docstrings