Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for rewrite hellper #1026

Merged

Conversation

TorkelE
Copy link
Contributor

@TorkelE TorkelE commented Dec 22, 2023

Also makes some updates to the functions and adds docstrings

@TorkelE TorkelE force-pushed the tests_for_rewrite_hellper branch from 2d0e2fa to 637b8e6 Compare March 15, 2024 19:51
@TorkelE
Copy link
Contributor Author

TorkelE commented Mar 15, 2024

With some exceptions ("LuxCore extensions Test" and "Groebner extension Test", which should be unrelated to this), tests passes locally. I think CI can be activated for the PR now (@shashi).

@@ -0,0 +1,134 @@
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably move ModelingToolkit.fixedpoint_sub here as well?

@ChrisRackauckas
Copy link
Member

Missing a docs page.

@YingboMa should review the implementation.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 76.25%. Comparing base (79c4e92) to head (a5de10a).
Report is 106 commits behind head on master.

Files Patch % Lines
src/rewrite-helpers.jl 77.77% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
- Coverage   77.07%   76.25%   -0.82%     
==========================================
  Files          32       34       +2     
  Lines        3533     3601      +68     
==========================================
+ Hits         2723     2746      +23     
- Misses        810      855      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TorkelE
Copy link
Contributor Author

TorkelE commented Mar 18, 2024

I have added entries in the docs now. Symbolics.occursin and Symbolics.filterchildren did not have very natural places, so I added these with Symbolics.replace.

Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisRackauckas ChrisRackauckas merged commit df632fd into JuliaSymbolics:master Mar 18, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants