feat: move fast_substitute to Symbolics, implement SII.symbolic_evaluate #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1089 +/- ##
==========================================
- Coverage 77.07% 76.10% -0.97%
==========================================
Files 32 35 +3
Lines 3533 3679 +146
==========================================
+ Hits 2723 2800 +77
- Misses 810 879 +69 ☔ View full report in Codecov by Sentry. |
|
This doesn't work for array expressions quite yet, and it would be nice if it did |
AayushSabharwal
force-pushed
the
as/sii-symbolic-eval
branch
from
078928d to
783ab25
Compare
AayushSabharwal
force-pushed
the
as/sii-symbolic-eval
branch
from
783ab25 to
f0268e1
Compare
| fixpoint_sub(ex, d; kwargs...) | ||
| end | ||
|
|
||
| function fixpoint_sub(x, dict; operator = Nothing) |
There was a problem hiding this comment.
Fixed in 33ce32b
| end | ||
|
|
||
| const Eq = Union{Equation, Inequality} | ||
| function fast_substitute(eq::Eq, subs; operator = Nothing) |
There was a problem hiding this comment.
Fixed in 33ce32b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.