Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Remove warning #1137

Merged
merged 3 commits into from
May 14, 2024

Conversation

NAThompson
Copy link
Contributor

When integrating Symbolics.jl with Latexify and ImageInTerminal, the following warning is emitted:

WARNING: method definition for supremum at /Users/nathompson7/.julia/packages/Symbolics/HDE84/src/domains.jl:22 declares type variable T but does not use it.

Fix it by removing the variable declaration.

When integrating Symbolics.jl with Latexify and ImageInTerminal,
the following warning is emitted:

```
WARNING: method definition for supremum at /Users/nathompson7/.julia/packages/Symbolics/HDE84/src/domains.jl:22 declares type variable T but does not use it.
```

Fix it by removing the variable declaration.
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 10.12%. Comparing base (79c4e92) to head (f971801).
Report is 164 commits behind head on master.

Files Patch % Lines
src/domains.jl 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1137       +/-   ##
===========================================
- Coverage   77.07%   10.12%   -66.95%     
===========================================
  Files          32       35        +3     
  Lines        3533     3623       +90     
===========================================
- Hits         2723      367     -2356     
- Misses        810     3256     +2446     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NAThompson
Copy link
Contributor Author

NAThompson commented May 12, 2024

To reproduce:

using Latexify
using Symbolics
using ImageInTerminal

function main()
    @variables x::Real y::Real

    expression = 2*x*y
    latexify(expression) |> s -> render(s, dpi=400)
end

if !isinteractive()
    main()
end

Output:

WARNING: Method definition isapprox(IntervalSets.AbstractInterval{T} where T, IntervalSets.AbstractInterval{T} where T) in module IntervalSets at ~/.julia/packages/IntervalSets/kyCuf/src/IntervalSets.jl:296 overwritten in module DomainSets at ~/.julia/packages/DomainSets/aafhp/src/domains/interval.jl:52.
ERROR: Method overwriting is not permitted during Module precompilation. Use `__precompile__(false)` to opt-out of precompilation.
WARNING: Method definition isapprox(IntervalSets.AbstractInterval{T} where T, IntervalSets.AbstractInterval{T} where T) in module IntervalSets at ~/.julia/packages/IntervalSets/kyCuf/src/IntervalSets.jl:296 overwritten in module DomainSets at ~/.julia/packages/DomainSets/aafhp/src/domains/interval.jl:52.
ERROR: Method overwriting is not permitted during Module precompilation. Use `__precompile__(false)` to opt-out of precompilation.
WARNING: method definition for supremum at ~/.julia/packages/Symbolics/HDE84/src/domains.jl:22 declares type variable T but does not use it.

Additional information:

$ julia --version
julia version 1.10.3

src/domains.jl Outdated Show resolved Hide resolved
src/domains.jl Outdated Show resolved Hide resolved
@ChrisRackauckas ChrisRackauckas merged commit 0b963e7 into JuliaSymbolics:master May 14, 2024
7 of 11 checks passed
@NAThompson NAThompson deleted the remove_warning branch May 14, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants