Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix coeff on divisions #1224

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix coeff on divisions #1224

merged 1 commit into from
Aug 22, 2024

Conversation

mxhbl
Copy link
Contributor

@mxhbl mxhbl commented Aug 20, 2024

This is a partial fix to issue #925, making coeff usable on divisions if the target symbol is not in the denominator.
This PR will result in coeff(x / y, x) returning 1 / y, instead of throwing an error, while coeff(x / (y + x), x) will still throw a not implemented error.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.56%. Comparing base (79c4e92) to head (62859ce).
Report is 320 commits behind head on master.

Files Patch % Lines
src/utils.jl 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
- Coverage   77.07%   76.56%   -0.52%     
==========================================
  Files          32       36       +4     
  Lines        3533     3746     +213     
==========================================
+ Hits         2723     2868     +145     
- Misses        810      878      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

oh awesome! Yeah that looks good.

@ChrisRackauckas ChrisRackauckas merged commit 783b1e4 into JuliaSymbolics:master Aug 22, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants