Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed output format of zero dimension sols #1237

Merged
merged 15 commits into from
Sep 7, 2024

Conversation

n0rbed
Copy link
Member

@n0rbed n0rbed commented Aug 25, 2024

Now, alex's latest issue #1235 's output is returned as

julia> symbolic_solve([(x - y) * (x - z) * (y - z)], [x,y,z])
2-element Vector{Dict{Num, Any}}:
 Dict(x => y)
 Dict(x => z)

instead of

julia> symbolic_solve([(x - y) * (x - z) * (y - z)], [x,y,z])
2-element Vector{Dict{Num, Any}}:
 Dict(z => z, y => y, x => y)
 Dict(z => z, y => y, x => z)

Also, a warning was added for non-cyclic polynomial systems for our multivar solver. Alex and i plan to implement its solution in the near future.

test/solver.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.24%. Comparing base (47cfd60) to head (fe29321).
Report is 55 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1237       +/-   ##
===========================================
+ Coverage    8.30%   80.24%   +71.93%     
===========================================
  Files          46       46               
  Lines        4549     4661      +112     
===========================================
+ Hits          378     3740     +3362     
+ Misses       4171      921     -3250     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sumiya11
Copy link
Contributor

I suppose the output should contain "Var => solution" for each variable Var that was requested in the call to symbolic_solve(..., [Var]) :

  • symbolic_solve([x - y, y - z], [x,y,z]) should return Dict(x => y, y => z, z => z)
  • symbolic_solve([x - y, y - z], [x,y]) should return Dict(x => y, y => z)
  • symbolic_solve([x - y, y - z], [x]) should return Dict(x => y)

what do you think ?

@sumiya11
Copy link
Contributor

symbolic_solve([x - y, y - z], [x,y,z]) should return Dict(x => y, y => z, z => z)

Outputing free variables as z => z is fine I suppose

@n0rbed
Copy link
Member Author

n0rbed commented Aug 28, 2024

symbolic_solve([x - y, y - z], [x]) should return Dict(x => y)

still to be done

@n0rbed n0rbed mentioned this pull request Sep 4, 2024
@ChrisRackauckas ChrisRackauckas merged commit f84b877 into JuliaSymbolics:master Sep 7, 2024
10 of 11 checks passed
@n0rbed n0rbed deleted the multivar_stuff branch September 8, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants