-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed output format of zero dimension sols #1237
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1237 +/- ##
===========================================
+ Coverage 8.30% 80.24% +71.93%
===========================================
Files 46 46
Lines 4549 4661 +112
===========================================
+ Hits 378 3740 +3362
+ Misses 4171 921 -3250 ☔ View full report in Codecov by Sentry. |
I suppose the output should contain "Var => solution" for each variable Var that was requested in the call to symbolic_solve(..., [Var]) :
what do you think ? |
Outputing free variables as z => z is fine I suppose |
symbolic_solve([x - y, y - z], [x]) should return Dict(x => y) still to be done |
Now, alex's latest issue #1235 's output is returned as
instead of
Also, a warning was added for non-cyclic polynomial systems for our multivar solver. Alex and i plan to implement its solution in the near future.