Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix latexify on complex expressions #1238

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

mxhbl
Copy link
Contributor

@mxhbl mxhbl commented Aug 25, 2024

At the moment, latexify fails on some complex expressions involving Symbolics.
For example,

using Symbolics, Latexify
latexify(im * Symbolics.Term(sqrt, [2]))

currently results in an error.

This PR is a small fix that resolves this error with minimal changes to the existing code. More work is probably needed to ensure complex pre-factors always display nicely.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.90%. Comparing base (47cfd60) to head (9cba874).
Report is 21 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1238       +/-   ##
===========================================
+ Coverage    8.30%   79.90%   +71.59%     
===========================================
  Files          46       46               
  Lines        4549     4633       +84     
===========================================
+ Hits          378     3702     +3324     
+ Misses       4171      931     -3240     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

It's at least a reasonable start, thanks!

@ChrisRackauckas ChrisRackauckas merged commit f6818bf into JuliaSymbolics:master Aug 26, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants